Case order bug #8748
Merged
Case order bug #8748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
case-order-bug
branch
from
a739b8f to
0e1841b
Compare
Codecov Report
@@ Coverage Diff @@
## master #8748 +/- ##
============================================
+ Coverage 62.81% 69.64% +6.82%
- Complexity 4556 4613 +57
============================================
Files 1679 1730 +51
Lines 88125 90321 +2196
Branches 13198 13424 +226
============================================
+ Hits 55354 62900 +7546
+ Misses 28801 23059 -5742
- Partials 3970 4362 +392
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
richardstartin
force-pushed
the
case-order-bug
branch
5 times, most recently
from
ab1c2b5 to
7114733
Compare
richardstartin
force-pushed
the
case-order-bug
branch
from
7114733 to
2af9c00
Compare
cliandy
reviewed
May 20, 2022
| _elseThenStatements.add(arguments.get(i)); | ||
| } | ||
| _selections = new boolean[_elseThenStatements.size()]; | ||
| Collections.reverse(_elseThenStatements); |
There was a problem hiding this comment.
Can we add a comment here to indicate the reasoning?
There was a problem hiding this comment.
Good suggestion, I'll follow up with cosmetic enhancements but want to get this merged quickly given the nature of the bug
walterddr
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in #8138 which eliminated the evaluation of never taken then statements, however, it also reversed the case order of precedence. This fixes this regression, but also adds a test to assert that correct case precedence is observed.
Fixes #8747